Workaround for proxy support in Windows 7 #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows7 supports proxy configuration through Autounattend.xml Unattended install sets everything needed to have a system-wide proxy configuration. The problem *seems* to be that it fails to notify wininet subsystem (sometimes or always, it depends, I don't really know why/how exactly) Anyways, this patch allow chocolatey to work reliably behind a proxy
|
I've been doing a lot of weird Windows debugging since I started working on malboxes but this must have been a rough one... Thank you so much for such a complete resolution to a hairy problem! |
obilodeau
added a commit
that referenced
this pull request
Sep 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows7 supports proxy configuration through
Autounattend.xmlUnattended install sets everything needed to have a system-wide proxy
configuration.
The problem seems to be that it fails to notify
wininetsubsystem(sometimes or always, it depends, I don't really know why/how exactly)
Anyways, this patch allow chocolatey to work reliably behind a proxy