Packer debugging with --debug #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done via injecting PACKER_LOG=1 environment variable. I needed to add optional environment alteration in run_foreground().
|
Looks good to me, which OS has this been tested on? |
|
I tested on Linux. Python docs on subprocess.Popen()'s env doesn't indicate that it would be problematic for Windows but it definitely could. Good point! |
|
Worked on Windows 10. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done via injecting
PACKER_LOG=1environment variable. I needed to add optional environment alteration inrun_foreground().This would have made troubleshooting #19 simpler so I added it.