[POC] 558 delete richdem from source #612
Open
+259
−304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adebardo
reviewed
Oct 23, 2024
|
The file dev-environment.yml is missing some modifications. |
vschaffn
force-pushed
the
558-delete_richdem_from_source
branch
from
3a40b4d
to
2b4a009
Compare
|
@duboise-cnes @adehecq @rhugonnet it's okay for me, what about you ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the ticket #558 that requires the removal of the
RichDEMdependency from the core functionnality of thexDEMproject to ensure the project's license is not impacted byRichDEM's GNU GPL v3.0 license.The changes made in this PR remove
RichDEMfrom operational code and ensure thatRichDEMis only used for testing purposes. Additionally, documentation and contribution guides have been updated to reflect this adjustment.Changes Implemented
Dependency Management
Updated
setup.cfganddev-environment.ymlto move therichdempackage from the mainoptdependencies to thetestsection.Source modifications
terrain.pyanddem.py, theuse_richdemparameter was removed from functions.RichDEMwere completely removed.Tests adjustments
RichDEMis still used in tests to ensure that all attribute functions give the same results as those ofRichDEM. The corresponding part of the code that has been removed from source was transfered toconftest.py.Documentation Updates
use_richdemparameter from functionsRichDEMis only used for testing purposes and is not required for the operation ofxdem.RichDEMshould only be used in tests, and core functionality ofxdemmust not rely onRichDEMto comply with the license.