Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homogenize typing between xDEM and GeoUtils #533

Open
rhugonnet opened this issue May 30, 2024 · 0 comments
Open

Homogenize typing between xDEM and GeoUtils #533

rhugonnet opened this issue May 30, 2024 · 0 comments
Labels
enhancement Feature improvement or request test-suite Issue related to testing

Comments

@rhugonnet
Copy link
Contributor

It's getting a bit confusing to have different definitions, we should choose between what we use, or come up with a new one that is consistent:

  • For an N-D floating or integer array, we currently use NDArrayf or NDArrayNum,
  • For an N-D boolean array, we currently use NDArrayb or NDArrayBool,

Same for ArrayLike inputs and Numeric.

Maybe we could also specify the shape of the arrays at some points!
@rhugonnet rhugonnet added documentation Improvements or additions to documentation enhancement Feature improvement or request test-suite Issue related to testing and removed documentation Improvements or additions to documentation labels May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature improvement or request test-suite Issue related to testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rhugonnet