Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secrets displayed twice if same content and same file is sent to multiscan endpoint #428

Closed
alina-tuholukova-gg opened this issue Nov 21, 2022 · 0 comments
Labels
status:confirmed This issue has been reviewed and confirmed type:bug Something isn't working

Comments

@alina-tuholukova-gg
Copy link
Contributor

alina-tuholukova-gg commented Nov 21, 2022

Environment

  • ggshield version: 1.14.1
  • Operating system (Linux, macOS, Windows): Linux
  • Operating system version: 20.04
  • Python version: 3.9

Describe the bug

The secret is shown twice if exactly the same file with the same content is present in the different commits.

Steps to reproduce:

  1. setup a repo, create a first commit on main branch
  2. create a branch B1 from main, add file with the secret, commit
  3. create a branch B2 from main, add same file with the secret (same name), commit
  4. scan repo with ggshield secret scan repo .

Actual result:
1st commit

  • secret
  • secret

2nd commit

  • secret
  • secret

Expected result:

1st commit

  • secret

2nd commit

  • secret
@alina-tuholukova-gg alina-tuholukova-gg added type:bug Something isn't working status:new This issue needs to be reviewed labels Nov 21, 2022
@agateau-gg agateau-gg added status:confirmed This issue has been reviewed and confirmed and removed status:new This issue needs to be reviewed labels Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:confirmed This issue has been reviewed and confirmed type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants