-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty try-catch block #292
Comments
@marjanjavid What is redundant here? |
@Karvan the empty |
@Foroughi Let's do this. |
@marjanjavid @Karvan Isn`t it better instead of we raise a warning for empty try-catch block , we raise a warning for every empty block not just try-catch block ? |
@Foroughi I am agree with you. The programmer can put comment in empty blocks to avoid get warning. Please note that we have rules for empty classes, empty methods and empty constructor and empty else clauses in GCop. |
@Karvan Do we need to add any fix providers for this case or only a warning would be enough? |
|
@Karvan If we have a block like below picture, we should warn about redundant code. Now we just warn about empty
finally
block.@Karvan Do you agree to add this rule?
The text was updated successfully, but these errors were encountered: