Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCop 651 #269

Open
marjanjavid opened this issue Feb 1, 2019 · 4 comments
Open

GCop 651 #269

marjanjavid opened this issue Feb 1, 2019 · 4 comments

Comments

@marjanjavid
Copy link
Collaborator

no warning is kicked

@marjanjavid
Copy link
Collaborator Author

The written example for this rule was wrong. I created a unit test for this rule on
https://gitlab.com/Paymon/GCop/commit/12ae6a86776bdbf15af1f3385681c19e38b4ec69

@Karvan
Copy link
Collaborator

Karvan commented Feb 12, 2019

@marjanjavid why this rule is in "Pre-Release"?

Is this a new rule or have we updated the logic?

@marjanjavid
Copy link
Collaborator Author

@Karvan This rule is still in Development branch, but as I have finished their task I moved theme to "Ore-Release" column in the work plan. I just added a new unit test for this rule. This is not a new rule , nor updated logic. Should I bring it back to the "In progress" column?

@Karvan
Copy link
Collaborator

Karvan commented Feb 12, 2019

While it's not about the development (new rule, bug, updating logic behind a rule) it shouldn't be in GCop Project kanban it must be in GCop Documentation.

And while you need to work on that it must be In Progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants