Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link preview image not displaying correct page title #4723

Open
tdlowden opened this issue May 1, 2024 · 3 comments
Open

Link preview image not displaying correct page title #4723

tdlowden opened this issue May 1, 2024 · 3 comments
Assignees
Labels
bug Software defect or bug

Comments

@tdlowden
Copy link
Member

tdlowden commented May 1, 2024

Image

Image

When linking to a catalog page, the link preview image contains Data.gov Home, data.gov. I believe it should show the page title of the page being linked.

How to reproduce

  1. Link to a catalog page in slack, x, facebook, etc
  2. View the link preview

Expected behavior

The link preview should cite the page Title of the page linked

Image

Actual behavior

The link preview displays "Data.gov Home" as the page title

Sketch

Fix the og:title to be the current page title

@tdlowden tdlowden added the bug Software defect or bug label May 1, 2024
@robert-bryson robert-bryson self-assigned this Sep 4, 2024
@robert-bryson
Copy link
Contributor

Initial attempt at GSA/ckanext-datagovtheme#212, but the embedded logic isn't quite working correctly so still working on the fix.

@robert-bryson
Copy link
Contributor

This is working correctly. Perhaps when updating previously CloudFront had been hitting the cache or something.

Image

Also, when discussing with @tdlowden, we noticed that the 11ty site did not have an image in the link preview. This should be added with this PR.

@robert-bryson
Copy link
Contributor

robert-bryson commented Sep 12, 2024

With GSA/catalog.data.gov#1452 this is deployed and working in prod.

Image

The additional fixup (beyond this ticket's scope, but related) for the 11ty site is still in progress.

Closing this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Software defect or bug
Projects
Status: Done
Development

No branches or pull requests

2 participants