Skip to content

Commit

Permalink
Merge pull request #290 from GEOS-ESM/tclune-patch-1
Browse files Browse the repository at this point in the history
Fixes #289 Correct CHANGELOG.md
  • Loading branch information
vbuchard authored Sep 27, 2024
2 parents b13cdb7 + 375fa54 commit ffa44c7
Showing 1 changed file with 20 additions and 15 deletions.
35 changes: 20 additions & 15 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed

- Modified the file paths in carbon, sulfate, and nitrate ExtData.yaml files to used the revised version of the CEDS anthropogenic emissions. Note the previous version has an incorrect seasonal cycle.
- Sulfate surface area density calculation in SU_Compute_Diags was incorrectly being passed the effective radius used for settling along with the sigma width of the number distribution. Properly it should be passed the number median radius, also present in the RC file. Added a hook to read that field from the RC file ("particle_radius_number"), store in SU grid comp, and pass to SU_Compute_Diags. This change is zero-diff to the SU internal state. It changes value of export SO4AREA.
- Changed DMS concentration data holder from ExtData provided (SU_DMSO) to local copy (dmso_conc). This is relevant since if we run source tagged instances where we don't want DMS emissions we would zero out dmso_conc and that is what should be passed to DMSemission subroutine. This is zero diff except in that case.
- It changes the formulation of the hydrophobic to hydrophilic conversion for carbon species,
now defined by a time scale specified in the instance RC file. This is now specified by providing
an e-folding time in days. This moves the time constant from outside the fortran to the run-time
configurable RC file. This is not quite zero-diff with original code because of the precision of
the specification, but testing shows nearly zero-diff result.

- Also now present in the carbon instance RC files is a run-time configurable optional
parameterized loss rate (e-folding time in days) per species and per mode. Default value for all is
set to "-1" which means no use of this function.
- Sulfate surface area density calculation in SU_Compute_Diags was incorrectly being passed the effective radius used for settling along with the sigma width of the number distribution.
Properly it should be passed the number median radius, also present in the RC file. Added a hook to read that field from the RC file ("particle_radius_number"), store in SU grid comp, and pass to SU_Compute_Diags.
This change is zero-diff to the SU internal state. It changes value of export SO4AREA.
- Changed DMS concentration data holder from ExtData provided (SU_DMSO) to local copy (dmso_conc).
This is relevant since if we run source tagged instances where we don't want DMS emissions we would zero out dmso_conc and that is what should be passed to DMSemission subroutine. This is zero diff except in that case.
- Changed SU2G_instance_SU.rc to now have separate filename inputs for explosive and degassing volcanoes
- It changes the formulation of the hydrophobic to hydrophilic conversion for carbon species, now defined by a time scale specified in the instance RC file.
This is now specified by providing an e-folding time in days. This moves the time constant from outside the fortran to the run-time configurable RC file.
This is not quite zero-diff with original code because of the precision of the specification, but testing shows nearly zero-diff result.
- Also now present in the carbon instance RC files is a run-time configurable optional parameterized loss rate (e-folding time in days) per species and per mode.
Default value for all is set to "-1" which means no use of this function.

### Fixed

Expand All @@ -41,14 +41,16 @@ set to "-1" which means no use of this function.
### Added

- Additional tuning parameters for the soil moisture and drylimit calculations for application specific tuning.
- Required attributes for the 2D GOCART export fields in AERO_DP bundle have been set in subroutine append_to_bundle in Chem_AeroGeneric.F90. These export fields are imported by OBIO via Surface GC, and the missing of the attributes was causing the writing of surface import checkpoint to fail. The issue has been explained in detail on https://github.com/GEOS-ESM/GOCART/issues/258
- Required attributes for the 2D GOCART export fields in AERO_DP bundle have been set in subroutine append_to_bundle in Chem_AeroGeneric.F90.
These export fields are imported by OBIO via Surface GC, and the missing of the attributes was causing the writing of surface import checkpoint to fail.
The issue has been explained in detail on https://github.com/GEOS-ESM/GOCART/issues/258
- Added export line to GOCART2G_GridCompMod to couple allow use of GOCART
SU sulfate production tendency elsewhere in Chemistry, specifically for
CARMA

- Update ESMF CMake target to `ESMF::ESMF`

- Changed SU2G_instance_SU.rc to now have separate filename inputs for explosive and degassing volcanoes

- Moved present volcanic emission inventories to one or the other line for these new entries; set other
line /dev/null; this is stop gap until next time we update volcanic emission inventories, at which
point will provide (for AMIP and AMIP.20C) separate explosive and degassing emissions
Expand All @@ -57,9 +59,12 @@ set to "-1" which means no use of this function.
until an actual split is made in the input emissions then the volcanic emissions are being assigned to
one or the other emission diagnostics (explosive or degassing).

- Changed Chem_SettlingSimple in the process library to call Mie Query for radius and rhop inputs to the settling velocity calculation. The calls to Chem_SettlingSimple were then changed accordingly in each of the species' grid comps. Since the RH flag is no longer needed, it was removed from GA_EnvironmentMod.F90 and each of the instance RC files.
- Changed Chem_SettlingSimple in the process library to call Mie Query for radius and rhop inputs to the settling velocity calculation.
The calls to Chem_SettlingSimple were then changed accordingly in each of the species' grid comps.
Since the RH flag is no longer needed, it was removed from GA_EnvironmentMod.F90 and each of the instance RC files.
- State Spec RC files for GOCART2G, CA, DU, NI, SU, and SS were updated such that the long names for AOD are more intuitive
- Modified ExtData.yaml files to persist as climatological anthropogenic emissions after the end of the CEDS dataset in 2019. Analogous rc files removed as this capability is only available with ExtData2G
- Modified ExtData.yaml files to persist as climatological anthropogenic emissions after the end of the CEDS dataset in 2019.
Analogous rc files removed as this capability is only available with ExtData2G
- Update `components.yaml` to match that of GEOSgcm v11.6.1
- ESMA_env v4.29.0 (Baselibs 7.24.0, Updates for SLES15 at NCCS, various fixes)
- ESMA_cmake v3.48.0 (Fixes for NAS, debug flags, Updates for SLES15 at NCCS, MPI detection, ESMF and MPI CMake fixes for Spack)
Expand Down

0 comments on commit ffa44c7

Please sign in to comment.