Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated AMV QC and thinning grids #81

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Updated AMV QC and thinning grids #81

wants to merge 2 commits into from

Conversation

ehlee96
Copy link

@ehlee96 ehlee96 commented Jan 25, 2022

I changed the code for AMV QC including :

  • remove IR, VIS winds at low level over lands
  • remove MSG IR winds over land for lat > 5N
  • (qc_satwnds) block the part that removes IR winds in the middle layer
  • For monitoring, assign missing information and add height assignment method
    And namelist(control) files were changed:
  • gmao_global_convinfo.txt for Jianjun's thinning grid change
  • gsi.rc.tmpl to turn on the logical variable(qc_satwnds)

Please help to review the above changes, and let me know if there is anything to modify.
Thanks.

@ehlee96 ehlee96 requested a review from a team as a code owner January 25, 2022 15:32
@ehlee96 ehlee96 added bugfix enhancement New feature or request observation configuration Change to configuration of obs input labels Jan 25, 2022
@gmao-jjin3 gmao-jjin3 self-requested a review February 17, 2022 19:33
gmao-jjin3
gmao-jjin3 reviewed Apr 12, 2022
View reviewed changes
GEOSaana_GridComp/GSI_GridComp/etc/gmao_global_convinfo.txt
uv 281 0 -1 3.0 0 0 0 6.0 6.1 1.4 6.0 0.005500 0 0. 0. 0 0. 0.
uv 282 0 1 3.0 0 0 0 6.0 6.1 1.4 6.0 0.005500 0 0. 0. 0 0. 0.
uv 284 0 -1 3.0 0 0 0 6.0 6.1 1.4 6.0 0.005500 0 0. 0. 0 0. 0.
uv 285 0 1 3.0 0 0 0 1.4 6.1 1.4 5.0 0.000500 1 100. 1200. 0 0. 0.
uv 286 0 -1 3.0 0 0 0 6.0 6.1 1.4 6.0 0.005500 0 0. 0. 0 0. 0.
uv 287 0 -1 3.0 0 0 0 6.0 6.1 1.4 6.0 0.000500 0 0. 0. 0 0. 0.
uv 289 0 1 3.0 0 0 0 5.0 6.1 1.4 5.0 0.000500 0 0. 0. 0 0. 0.
uv 290 4 -1 3.0 0 0 0 5.0 6.1 1.4 5.0 0.000500 1 100. 1200. 0 0. 0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this type of ASCAT wind was not actually tested, iuse=-1 here, in the x0046wd experiment, I'd suggest we keep the original thinning grid size which is 100 km.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmao-jjin3 gmao-jjin3 gmao-jjin3 approved these changes

@karpob karpob Awaiting requested review from karpob

@rtodling rtodling Awaiting requested review from rtodling

@asewnath asewnath Awaiting requested review from asewnath

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bugfix enhancement New feature or request observation configuration Change to configuration of obs input
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehlee96 @gmao-jjin3 @rtodling