Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/jjin3/allsky mw cloud retrieval qc flag #137

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

gmao-jjin3
Copy link
Contributor

@gmao-jjin3 gmao-jjin3 commented Jun 30, 2023

Add a qc_flag of failed microwave cloud function using simulated brightness temperature (Tb) in all-sky DA. Observation should be tossed out when cloud amount cannot be derived from observed Tb or simulated Tb, but current GSI fails in doing that. See the note:
GEOS-ESM/swell#66 (comment)

A failure in cloud function using observed Tb or simulated Tb results in the observation being tossed in JEDI/UFO. Therefore, this PR would make this QC identical in GSI and JEDI though impact in final analysis is likely trivial.

@gmao-jjin3 gmao-jjin3 added the Non 0-diff The changes in this pull request are non-zero-diff label Jun 30, 2023
@gmao-jjin3 gmao-jjin3 requested a review from a team as a code owner June 30, 2023 19:08
@gmao-jjin3 gmao-jjin3 self-assigned this Jun 30, 2023
Copy link
Contributor

@gmao-yzhu gmao-yzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look fine to me.

Copy link
Contributor

@rtodling rtodling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this in the context of 5.30 and it seems fine w/ me - the change knocks out a handful of observations - taking into 5.30

@rtodling rtodling merged commit 9cc856a into develop Sep 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Non 0-diff The changes in this pull request are non-zero-diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants