Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip identical conventional observations. #126

Merged
merged 5 commits into from
Sep 13, 2023

Conversation

gmao-jjin3
Copy link
Contributor

A few minor changes in order to make inflated observational errors of conventional observations identical to those values in GEOS.
(1) Keep only one of those conventional observations which are made at the same locations, level, and time, and discard the rest of them. As a result, we can avoid losing those data in IODA converter, and have same duplicate factors in JEDI as in GSI.
(2) Determine duplicate factors by single precision geo-location values since single precision values are saved in NC_Diag files and then used in JEDI/UFO.
(3) Not to consider sensible temperature and virtual temperature made at same locations as duplicated observations.
(4) Save observation types (kx) of duplicated observations in NC_Diag files.

@gmao-jjin3 gmao-jjin3 requested a review from a team as a code owner March 23, 2023 17:47
@github-actions
Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found:

@gmao-jjin3 gmao-jjin3 self-assigned this Mar 23, 2023
@gmao-jjin3 gmao-jjin3 added enhancement New feature or request Non 0-diff The changes in this pull request are non-zero-diff labels Mar 23, 2023
@gmao-jjin3
Copy link
Contributor Author

@rtodling I saw your email yesterday and I tend to withdraw these changes. They are merely for UFO configuration. I don't know exactly how significant their impact in GSI. We probably don't want add these changes in GSI if the impact is significant. If the impact is insignificant, on the other hand, those differences in inflated errors between GSI and UFO should have insignificant impact in JEDI results too. @danholdaway how do you think?

@rtodling
Copy link
Contributor

I commented the prints in the setup's here related to the duplicate obs ... too many of them.

Copy link
Contributor

@rtodling rtodling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. I did a little test; I see some obs get tossed, but only very few - looks good. Thanks.

@gmao-jjin3
Copy link
Contributor Author

I commented the prints in the setup's here related to the duplicate obs ... too many of them.

No problem at all.

@rtodling rtodling merged commit 421257a into develop Sep 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Non 0-diff The changes in this pull request are non-zero-diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants