Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Curved movement] Certain easing functions cause TweenPathMovement to never finish #1320

Open
1 task done
Granshmeyr opened this issue Jun 18, 2024 · 0 comments
Open
1 task done
Labels
⚠ Issue with an extension An issue with an extension that is already on the extension store

Comments

@Granshmeyr
Copy link

Granshmeyr commented Jun 18, 2024

Is there an existing issue for this?

Enter the name of the extension

Curved movement

Describe the bug of the extension

The easing functions "easeInBack" and "swingFrom" cause TweenPathMovement to never finish its movement. This means the Finished to move and Reached an end conditions never return true. The output of behavior.Progress() stops at 0.9999999999999998.

Steps to reproduce

  1. Clone MRP from https://github.com/Granshmeyr/GDevelop-CurvedMovement-MRP
  2. Run game
  3. Read the screen and scroll to "easeInBack" & "swingFrom"
  4. Notice how the square never turns green for these easing functions

GDevelop platform

Desktop

GDevelop version

5.4.203

Platform info

Windows

Windows 11 Home

Desktop

Additional context

Temporary solution is to evaluate the expression Math.abs(pathBehavior.Progress() - 1) <= Number.EPSILON or something similar to eliminate the obvious floating point error.

@Granshmeyr Granshmeyr added the ⚠ Issue with an extension An issue with an extension that is already on the extension store label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠ Issue with an extension An issue with an extension that is already on the extension store
Projects
None yet
Development

No branches or pull requests

1 participant