-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider splitting up test namespaces into another project? #197
Comments
It was suggested when we began the project that the test component could be housed elsewhere. However, there was quite a strong desire for jackdaw to include tools that could be used for testing as well as implementing a kafka based system. As you've noted, manifold is also used by the admin ns which fuzzes the issue slightly as there are now 2 top-level namespaces that would break if you exclude aleph when depending on jackdaw (i.e. jackdaw.admin and jackdaw.test). Not sure it would be that easy to remove though for someone who doesn't know the underlying Java primitives that well :-) I think if anything, there's some useful async code under the test namespace that should probably be slightly refactored and moved into a non-test namespace and made available for folks that want to use the kafka client in an asynchronous fashion. |
+1 on this, but manifold is not a massive issue, the problem is more that aleph brings in netty as well. Aleph could still be an optional dependency and the test machine could maybe only work if that's available? |
From this simple attempt #360 |
When we included jackdaw in our project our uberjar size grew about ~20-30mb (most of that is Kafka libs of course). jackdaw is bringing in
aleph
and transitivelymanifold
which appears to only really be used in the test related namespaces (the admin namespace uses manifold in a few spots which seem easy to remove) increasing our jar ~5MB. It would be nice to bring in a dependency like[fundingcircle/jackdaw-test "0.6.8"]
instead? I can of course exclude these dependencies which I have, just a thought!The text was updated successfully, but these errors were encountered: