Add LRU Session Cache to Reduce RAM Usage #6239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for 9188c18Click to view benchmark
|
Benchmark for 4d3a6baClick to view benchmark
|
JoshuaBatty
force-pushed
the
josh/lru_sessions
branch
from
6c78dfc
to
0b77942
Compare
Benchmark for 6361215Click to view benchmark
|
Benchmark for 5cc7639Click to view benchmark
|
kayagokalp
approved these changes
Jul 10, 2024
Nothing concrete. I was just looking at activity monitor and seeing the memory usage between clicking into new projects in the FUSD workspace. Previously we just kept adding more without a cap. opening 20 projects in that repo got to about 30gb so about 660mb per project. This should at least keep us 2-3gb usage range now. But strongly agree that adding a CI step for this would be very useful if we can find the capacity to implement it. |
IGI-111
approved these changes
Jul 10, 2024
Benchmark for 168f9fbClick to view benchmark
|
esdrubal
pushed a commit
that referenced
this pull request
Aug 13, 2024
## Description This PR introduces an LRU (Least Recently Used) cache mechanism for managing sessions in large workspaces. This change aims to address the issue of high RAM usage reported in workspaces with multiple projects. closes #6222 ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [x] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces an LRU (Least Recently Used) cache mechanism for managing sessions in large workspaces. This change aims to address the issue of high RAM usage reported in workspaces with multiple projects.
closes #6222
Checklist
Breaking*orNew Featurelabels where relevant.