-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow storage access in fallback only contracts #6031
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IGI-111
force-pushed
the
IGI-111/fallback-only
branch
2 times, most recently
from
May 19, 2024 16:09
370e348
to
e115645
Compare
IGI-111
added
the
breaking
May cause existing user code to break. Requires a minor or major release.
label
May 19, 2024
Benchmark for a0f806fClick to view benchmark
|
IGI-111
force-pushed
the
IGI-111/fallback-only
branch
from
May 19, 2024 16:39
e115645
to
f463e58
Compare
Benchmark for c9fcce9Click to view benchmark
|
IGI-111
force-pushed
the
IGI-111/fallback-only
branch
from
May 20, 2024 07:39
f463e58
to
9a08ebd
Compare
Benchmark for 9250810Click to view benchmark
|
IGI-111
force-pushed
the
IGI-111/fallback-only
branch
from
May 20, 2024 08:15
9a08ebd
to
3d228e0
Compare
Benchmark for 6025ae0Click to view benchmark
|
Contract that do not implement any ABI (and therefore have no methods) do not always properly set the storage annotations of the entry function because the fallback function's storage annotations are not taken into account. This changes makes sure that the storage function's storage permissions are also considered.
IGI-111
force-pushed
the
IGI-111/fallback-only
branch
from
May 20, 2024 08:45
3d228e0
to
876cfba
Compare
Benchmark for 261b494Click to view benchmark
|
xunilrj
approved these changes
May 21, 2024
JoshuaBatty
approved these changes
May 21, 2024
Benchmark for 0c91717Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contract that do not implement any ABI (and therefore have no methods) do not always properly set the storage annotations of the entry function because the fallback function's storage annotations are not taken into account. This changes makes sure that the storage function's storage permissions are also considered.
We also change the code generation for the method selector to make selection optional, such as for full passthrough proxies.
Checklist
Breaking*
orNew Feature
labels where relevant.