Refactor: Imports must use absolute paths #5697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for f86c780Click to view benchmark
|
Benchmark for 595dfe2Click to view benchmark
|
Benchmark for 6c5cf66Click to view benchmark
|
Benchmark for 701f4aeClick to view benchmark
|
tritao
added
compiler
IGI-111
previously approved these changes
Mar 7, 2024
Benchmark for 5778c2dClick to view benchmark
|
IGI-111
approved these changes
Mar 8, 2024
tritao
approved these changes
Mar 8, 2024
Benchmark for 3c82d13Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains the final bit of refactoring before I start fixing the import problems mentioned in #5498.
The semantics of imports has so far been implemented in the
Modulestruct, and has assumed that the destination path of an import was relative toself. In particular, this allows imports to any submodule of the current module.However, whenever that logic was triggered by the compiler the destination path was always absolute. The only reason this worked was that the logic was only ever triggered on the root module.
To reflect this behavior I have therefore moved the import semantics to the
Rootstruct, and made it clear in the comments that the paths are assumed to be absolute.This also reflects the fact that once the module structure has been populated with the imported entities we don't actually need the import logic anymore, so it shouldn't be located in the
Modulestruct. (Name resolution should obviously stay in theModulestruct, so that logic has not been moved).I have left a couple of TODOs in the code to remind myself where I need to make changes when I start implementing
pub use(see #3113 ).Checklist
Breaking*orNew Featurelabels where relevant.