Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate Items::use_aliases #5912

Closed
jjcnn opened this issue Apr 23, 2024 · 1 comment · Fixed by #5931
Closed

Eliminate Items::use_aliases #5912

jjcnn opened this issue Apr 23, 2024 · 1 comment · Fixed by #5931
Assignees
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen

Comments

@jjcnn
Copy link
Contributor

jjcnn commented Apr 23, 2024

Aliased imports, e.g.

use a::b as c;

are currently represented using two maps:

  • Items::use_synonyms, which maps b to the declaration of b in module a.
  • Items::use_aliases, which maps a to the name b.

There really is no reason two have both maps, since the name b is not in scope when using an aliased import.

@jjcnn jjcnn added the compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen label Apr 23, 2024
@jjcnn
Copy link
Contributor Author

jjcnn commented Apr 25, 2024

Related to this, aliased imports are not reexported correctly:

import x::y; // this gets reexported as y
import z::w as v; // this does not get reexported, neither as w nor as v

Eliminating use_aliases and only binding the aliased name should fix this issue.

@jjcnn jjcnn self-assigned this Apr 25, 2024
tritao pushed a commit that referenced this issue May 2, 2024
## Description

Fixes #5912, #5713 .

Item imports with aliases `use x::y as z` have so far been represented
using two maps:
- A synonyms map mapping `y` to the type declaration of `x::y`.
- An alias map mapping `z` to `y`.

This is confusing, since `y` is not actually bound by this import, and
unsurprisingly has lead to a bug because of a name capture (see #5713).

This PR eliminates the alias mapping, and changes the synonyms map to
map `z` to the type declaration of `x::y`.

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant