Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ensure that we fetch node info per estimation #3324

Merged
merged 17 commits into from
Oct 14, 2024

Conversation

maschad
Copy link
Member

@maschad maschad commented Oct 13, 2024

Closes #3315

Release notes

In this release, we:

  • Improved Provider cache to self-clean on TX dry-run/estimation

Summary

Given that the consensus parameters may be updated on a weekly basis, we should try and fetch new consensus parameters before submitting a transaction. Kudos to @nedsalk and @arboleya for the assistance.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Copy link

vercel bot commented Oct 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 1:36am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 1:36am

@github-actions github-actions bot added the bug Issue is a bug label Oct 13, 2024
Copy link

codspeed-hq bot commented Oct 13, 2024

CodSpeed Performance Report

Merging #3324 will not alter performance

Comparing mc/feat/fetch-updated-consensus-params (dfd33b9) with master (987aed3)

Summary

✅ 18 untouched benchmarks

@maschad maschad changed the title fix: ensure that we fetch node info per estimation feat: ensure that we fetch node info per estimation Oct 13, 2024
@github-actions github-actions bot added the feat Issue is a feature label Oct 13, 2024
arboleya
arboleya previously approved these changes Oct 14, 2024
Torres-ssf
Torres-ssf previously approved these changes Oct 14, 2024
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
76.11%(+0.04%) 70.06%(+0.06%) 75.09%(+0.03%) 76.24%(+0.04%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/provider.ts 69.91%
(+0.89%)
62.1%
(+1.15%)
71.27%
(+0.31%)
69.61%
(+0.88%)
🔴 packages/account/src/providers/generated/operations.ts 94.66%
(+0.07%)
100%
(+0%)
84%
(+0.33%)
95.09%
(+0.06%)

@arboleya arboleya merged commit 6b7b6de into master Oct 14, 2024
24 checks passed
@arboleya arboleya deleted the mc/feat/fetch-updated-consensus-params branch October 14, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Provider caching strategy
5 participants