-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create fuels
template optimisations
#3143
Conversation
…ion and faucet redirect on safari/mobile
Deployment failed with the following error:
View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
…/chore/template-improvements
…irect to home page after fauceting
…uelLabs/fuels-ts into db/chore/template-improvements
…uelLabs/fuels-ts into db/chore/template-improvements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @rishabhkeshan, my comments should be applied to all instances across both templates.
@Dhaiwat10 Is this likely to impact docs or integration tests?
…creased refreshWalletBalance interval on faucet to 3 seconds
…uelLabs/fuels-ts into db/chore/template-improvements
@danielbate @Torres-ssf thanks for the review, have incorporated all the suggestions |
@danielbate it might if the UI has changed in a certain way. The only way to really know is to run them I think |
Coverage Report:
Changed Files:Coverage values did not change👌. |
Closing this for now, we've run into issues with the integration tests when removing the wallet abstractions. These are problems we'll also need to solve for #3125 so we'll be syncing up with @rishabhkeshan to get these over the line, but it's likely that this PR will be superceded. |
create fuels
Template Optimisations #3088Summary
Includes the following optimizations on the Next and Vite templates as per @SilentCicero's feedback:
Top-up Wallet
button with a single faucet button (remove the faucet button from the left hand nav).target="_blank"
and opens in a new tab.Fuel Docs
link beside theHome
button as another nav linkBack to home
links, we already have a home button in the navChecklist