Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create fuels template optimisations #3143

Closed
wants to merge 28 commits into from

Conversation

rishabhkeshan
Copy link
Contributor

@rishabhkeshan rishabhkeshan commented Sep 11, 2024

Fixes TS-622

Summary

Includes the following optimizations on the Next and Vite templates as per @SilentCicero's feedback:

  • Replace the Top-up Wallet button with a single faucet button (remove the faucet button from the left hand nav).
  • Reduce the transfer amounts for the predicate example, the amount is not suitable for testnet
  • Predicate text not displaying correctly on mobile, may be resolved by generally reducing mobile body padding
  • Ensure all externally routing links have target="_blank" and opens in a new tab.
  • Ensure faucet is embedded and for Safari/Mobile there is a redirect to the faucet url and back.
  • Balance should update on tx submission
  • Move Fuel Docs link beside the Home button as another nav link
  • Improve error handling when unconnected, currently it has the default tx fail error messages, we should provide something more specific, we could grey out the action buttons when no wallet is connected
  • Remove the Back to home links, we already have a home button in the nav
  • Transaction pending state, when a transaction is pending the active button should reflect that
  • Mobile formatting fixes - reduce body padding significantly and make mobile nav links cover entire width
  • Burner wallet issues? We may need to do some additional debugging / integration tests here to debug

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Copy link

vercel bot commented Sep 11, 2024

Deployment failed with the following error:

You don't have permission to create a Preview Deployment for this project.

View Documentation: https://vercel.com/docs/accounts/team-members-and-roles

@rishabhkeshan rishabhkeshan changed the title Db/chore/template improvements Feat: Next and Vite Template Improvements Sep 11, 2024
@rishabhkeshan rishabhkeshan changed the title Feat: Next and Vite Template Improvements feat: Next and Vite Template Improvements Sep 11, 2024
@github-actions github-actions bot added the feat Issue is a feature label Sep 11, 2024
Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 9:10am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 9:10am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 18, 2024 9:10am

Dhaiwat10
Dhaiwat10 previously approved these changes Sep 17, 2024
Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @rishabhkeshan, my comments should be applied to all instances across both templates.

@Dhaiwat10 Is this likely to impact docs or integration tests?

templates/nextjs/src/app/faucet/page.tsx Outdated Show resolved Hide resolved
templates/nextjs/src/app/page.tsx Outdated Show resolved Hide resolved
templates/vite/src/components/Navbar.tsx Show resolved Hide resolved
@rishabhkeshan
Copy link
Contributor Author

@danielbate @Torres-ssf thanks for the review, have incorporated all the suggestions

@Dhaiwat10
Copy link
Member

@danielbate it might if the UI has changed in a certain way. The only way to really know is to run them I think

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
77.16%(+0%) 71.81%(+0%) 75.77%(+0%) 77.27%(+0%)
Changed Files:

Coverage values did not change👌.

@danielbate
Copy link
Contributor

Yeah unfortunately the UI tests are failing for me. Docs will also need updating 🤔

Screenshot 2024-09-18 at 10 43 50

@danielbate
Copy link
Contributor

Closing this for now, we've run into issues with the integration tests when removing the wallet abstractions. These are problems we'll also need to solve for #3125 so we'll be syncing up with @rishabhkeshan to get these over the line, but it's likely that this PR will be superceded.

@danielbate danielbate closed this Sep 18, 2024
@arboleya arboleya deleted the db/chore/template-improvements branch September 18, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create fuels Template Optimisations
5 participants