Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade connectors #3012

Merged
merged 9 commits into from
Aug 23, 2024
Merged

chore: upgrade connectors #3012

merged 9 commits into from
Aug 23, 2024

Conversation

danielbate
Copy link
Contributor

@danielbate danielbate commented Aug 22, 2024 •
edited
Loading

Summary

Upgrade @fuels/connectors and @fuels/react to 0.25.0 for stability with dependency issues, thus resolving the broken integration test. I had some trouble upgrading the wallet-sdk-react-demo, had some obscure errors but seemed to be resolved by upgrading the create next-app templating. I didn't have the same problem with the other next apps.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@danielbate danielbate added the chore Issue is a chore label Aug 22, 2024
@danielbate danielbate self-assigned this Aug 22, 2024
@danielbate danielbate marked this pull request as ready for review August 22, 2024 16:34
Torres-ssf
Torres-ssf previously approved these changes Aug 22, 2024
View reviewed changes
maschad
maschad previously approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @danielbate

@maschad maschad dismissed their stale review August 22, 2024 17:53

There's a minor linting issue @danielbate so I am just dismissing this review until that is addressed, otherwise LGTM

@danielbate danielbate mentioned this pull request Aug 23, 2024
Merged
4 tasks
@danielbate danielbate enabled auto-merge (squash) August 23, 2024 12:52
@arboleya
Copy link
Member

@danielbate 🚢?

@danielbate
Copy link
Contributor Author

@arboleya hmm 🤔

Screenshot 2024-08-23 at 14 19 05

@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.42%(+0%) 71.75%(-0.04%) 77.84%(+0%) 79.55%(+0%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.48%
(+0%)		 78.26%
(-1.45%)		 84%
(+0%)		 88.73%
(+0%)

@danielbate danielbate merged commit 8c47dc5 into master Aug 23, 2024
20 checks passed
@danielbate danielbate deleted the db/chore/upgrade-connectors branch August 23, 2024 13:49
@fuel-service-user fuel-service-user mentioned this pull request Aug 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya approved these changes

@maschad maschad maschad approved these changes

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@petertonysmith94 petertonysmith94 Awaiting requested review from petertonysmith94 petertonysmith94 is a code owner

Assignees

@danielbate danielbate

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix integration / UI tests for create-fuels Upgrade connectors in apps and template to 0.25.0
4 participants
@danielbate @arboleya @maschad @Torres-ssf