Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: find deeply nested option coders #2325

Merged
merged 14 commits into from
May 17, 2024

Conversation

danielbate
Copy link
Contributor

@danielbate danielbate commented May 17, 2024

Extension of #2322 to include deeply nested search for option.

@danielbate danielbate self-assigned this May 17, 2024
@danielbate danielbate changed the title feat: deeply nested type for coders feat: find deeply nested option coders May 17, 2024
@danielbate danielbate changed the title feat: find deeply nested option coders feat: find deeply nested option coders May 17, 2024
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.84%(+0.02%) 70.71%(+0.15%) 76.87%(-0.03%) 79.92%(+0.01%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/abi-coder/src/utils/utilities.ts 63.63%
(+43.63%)
92.3%
(+92.3%)
66.66%
(+16.66%)
65.21%
(+37.94%)

@arboleya
Copy link
Member

Would this also close #2323, or that should require another PR?

If the latter, should we release without it or only when it's completed?

@danielbate
Copy link
Contributor Author

@arboleya it does improve it but until we have actual validation checks for Option::None I don't want to close it. But I don't think we need to ship it with it. As we still have validation on the option child level (i.e Option<u8> would be validated at the u8 level by NumberCoder.

@danielbate danielbate merged commit 0b8e1a8 into master May 17, 2024
19 checks passed
@danielbate danielbate deleted the db/feat/find-deeply-nested-types-for-coders branch May 17, 2024 11:28
@danielbate danielbate added the feat Issue is a feature label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants