Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added linting for pnpm-lock file quotes #2301

Merged
merged 9 commits into from
May 15, 2024
Merged

chore: added linting for pnpm-lock file quotes #2301

merged 9 commits into from
May 15, 2024

Conversation

petertonysmith94
Copy link
Contributor

Adds linting to our pnpm-lock.yaml to allow for consistent quotes which enables reviewing of the dependency changes in the lock file.

Examples of these changes here and here.

@petertonysmith94 petertonysmith94 added the chore Issue is a chore label May 14, 2024
@petertonysmith94 petertonysmith94 self-assigned this May 14, 2024
@petertonysmith94 petertonysmith94 changed the title Added linting for pnpm-lock file quotes chore: added linting for pnpm-lock file quotes May 14, 2024
@petertonysmith94 petertonysmith94 marked this pull request as ready for review May 14, 2024 14:22
maschad
maschad reviewed May 14, 2024
View reviewed changes
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to enable reviewing the lockfile on github? because that's still not possible.

@petertonysmith94
Copy link
Contributor Author

@maschad It should be possible given the quotes remain constant so the diff is manageable (an example). I've added linting to ensure that single quotes are always used.

maschad
maschad requested changes May 14, 2024
View reviewed changes
Copy link
Member

@maschad maschad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is still a linting issue

maschad
maschad approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.79%(+0.25%) 70.47%(+0.63%) 76.85%(-0.27%) 79.88%(+0.23%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/abi-coder/src/AbiCoder.ts 75%
(+0%)		 0%
(-100%)		 66.66%
(+0%)		 75%
(+0%)
🔴 packages/abi-coder/src/FunctionFragment.ts 65.38%
(-4.18%)		 60%
(-9.69%)		 71.42%
(-1.91%)		 64.81%
(-4.63%)
🔴 packages/abi-coder/src/Interface.ts 72%
(+0%)		 60%
(-2.5%)		 76.92%
(+0%)		 71.42%
(+0%)
✅ ✨ packages/abi-coder/src/encoding/coders/ArrayCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/B256Coder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/B512Coder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/BigNumberCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/BooleanCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/ByteCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/EnumCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/NumberCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/OptionCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
🔴 ✨ packages/abi-coder/src/encoding/coders/RawSliceCoder.ts 94.44%
(+94.44%)		 83.33%
(+83.33%)		 100%
(+100%)		 94.44%
(+94.44%)
✅ ✨ packages/abi-coder/src/encoding/coders/StdStringCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/StrSliceCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/StringCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/StructCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/TupleCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
✅ ✨ packages/abi-coder/src/encoding/coders/VecCoder.ts 100%
(+100%)		 100%
(+100%)		 100%
(+100%)		 100%
(+100%)
🔴 packages/abi-coder/src/encoding/strategies/getCoderV1.ts 91.48%
(-0.18%)		 86.66%
(+0%)		 100%
(+0%)		 91.66%
(+0%)
🔴 packages/abi-coder/src/utils/constants.ts 97.36%
(-0.07%)		 100%
(+0%)		 0%
(+0%)		 97.36%
(-0.07%)
🔴 packages/abi-coder/src/utils/utilities.ts 20%
(-76.49%)		 0%
(-80%)		 50%
(-50%)		 27.27%
(-69.45%)
🔴 packages/account/src/account.ts 82.78%
(-0.22%)		 66.66%
(+0%)		 76%
(+0%)		 82.35%
(-0.23%)
🔴 packages/account/src/mnemonic/utils.ts 97.61%
(+19.15%)		 91.66%
(+28.03%)		 100%
(+0%)		 97.77%
(+18.06%)
🔴 packages/account/src/predicate/predicate.ts 24.19%
(+1.81%)		 31.25%
(+0%)		 13.33%
(+0.83%)		 23.07%
(+1.65%)
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 85.91%
(+0.4%)		 75%
(+2.17%)		 86%
(-0.53%)		 86.3%
(+0.4%)
🔴 packages/account/src/providers/transaction-summary/call.ts 6.25%
(+1.49%)		 0%
(+0%)		 0%
(+0%)		 6.25%
(+1.49%)
🔴 packages/program/src/contract-call-script.ts 10.97%
(+0.14%)		 0%
(+0%)		 0%
(+0%)		 10.58%
(+0.02%)
🔴 packages/program/src/functions/multicall-scope.ts 0%
(+0%)		 100%
(+100%)		 0%
(+0%)		 0%
(+0%)
🔴 ✨ packages/utils/src/utils/toUtf8Bytes.ts 88%
(+88%)		 84.61%
(+84.61%)		 100%
(+100%)		 88.46%
(+88.46%)
🔴 ✨ packages/utils/src/utils/toUtf8String.ts 94.64%
(+94.64%)		 92.3%
(+92.3%)		 100%
(+100%)		 94.73%
(+94.73%)

@petertonysmith94 petertonysmith94 merged commit 8a6106c into master May 15, 2024
19 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/chore/linting-pnpm-lock branch May 15, 2024 07:09
petertonysmith94 added a commit that referenced this pull request May 30, 2024
@petertonysmith94
Revert "chore: added linting for pnpm-lock file quotes (#2301)"
e69e5fb 
This reverts commit 8a6106c.
petertonysmith94 added a commit that referenced this pull request May 30, 2024
@petertonysmith94
chore: revert linting for pnpm-lock file (#2418)
eb4d531 
Revert "chore: added linting for pnpm-lock file quotes (#2301)"

This reverts commit 8a6106c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbate danielbate danielbate approved these changes

@maschad maschad maschad approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

Assignees

@petertonysmith94 petertonysmith94

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petertonysmith94 @danielbate @maschad @arboleya