-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add a section for numbers #1768
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we think it's a good idea to introduce a BigInt
example also, as those working with ethers
made need assistance with conversions?
Additionally a sub paragraph on handling and differentiating big numbers I think would be beneficial. As you only need bn
for u64
.
Co-authored-by: Daniel Bate <djbate23@gmail.com>
@danielbate as in, how does one convert a
Interesting. Did not know that. So, for the smaller types - we can directly pass in JavaScript numbers? |
This may not even be possible, but
Yes exactly that, so if we look at the
The value to be encoded is expecting a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one Dhai 💪🏻 Just one thought, may be irrelevant so approving.
@Torres-ssf @danielbate thanks for the heads-up, investigating u256 support |
Pull request was converted to draft
This reverts commit 06727de.
@danielbate @Torres-ssf you were right lads, we dont support Should I also create an issue to add support for this type? @arboleya |
Coverage Report:
Changed Files:Coverage values did not change👌. |
Hmm, good catch. Let's also check if the Rust SDK has it. There may be some reason it has never been added; it's worth investigating. But yes, unless there's some strong reason behind it, feel free to create an issue. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
Closes #1555