-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create a wallet without a provider #1566
Merged
Torres-ssf
merged 56 commits into
FuelLabs:rc/salamander
from
petertonysmith94:ps/feat/allow-wallet-creation-without-provider
Jan 18, 2024
Merged
Changes from all commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
75e1036
test: added test for setting Account.provider field
petertonysmith94 0acd706
test: added distinction to test, with a provider
petertonysmith94 c901a66
test: added Account without a provider tests
petertonysmith94 36bb89c
feat: made provider optional on the Account class
petertonysmith94 067317b
feat: removed redundant provider variable on BaseWalletUnlocked (expo…
petertonysmith94 4a3c6ed
feat: made provider variable protected
petertonysmith94 8bbd0a1
chore: added missing typedocs for `fromEncryptedJson` method
petertonysmith94 0d0419d
feat: made BaseWalletUnlocked provider argument optional
petertonysmith94 8f3c09e
chore: fixed the order of the typedocs (Wallet.fromSeed)
petertonysmith94 348b045
chore: fixed the order of the typedocs (Wallet.fromMnemonic)
petertonysmith94 c97879b
test: removed duplicate test
petertonysmith94 6a683b4
test: added clearer test intentions
petertonysmith94 49a6ae0
feat: make provider argument optional on Wallet.fromAddress
petertonysmith94 28d740a
feat: make provider argument optional on Wallet.fromPrivateKey
petertonysmith94 bdcf761
chore: updated typedocs on Account class - provider optional
petertonysmith94 1d006d7
feat: make arguments optional on Wallet.generate
petertonysmith94 ce42fa0
test: tiding up the wallet tests
petertonysmith94 1fa96c9
test: missing Wallet instantiate from generate
petertonysmith94 38aa397
fix: failing test - incorrect instance
petertonysmith94 4fa4b13
test: organising tests by function name
petertonysmith94 3970303
chore: added todo for question
petertonysmith94 1fd7411
test: added describe block around tests
petertonysmith94 28fe1d7
test: fromSeed without provider
petertonysmith94 8923259
feat: fromMnemonic optional provider
petertonysmith94 8e22bd2
test: fromExtendedKey provider optional
petertonysmith94 ccdd425
test: fixing incorrect instance type
petertonysmith94 67c7cf1
feat: made fromEncryptedJson provider argument optional
petertonysmith94 e076212
test: fixed name of test
petertonysmith94 291a4e1
test: added expects for provider error
petertonysmith94 922b762
test: describe the underlying class
petertonysmith94 dc9ae02
test: make test a little more organised
petertonysmith94 01b0e6f
Merge branch 'master' into ps/feat/allow-wallet-creation-without-prov…
petertonysmith94 79417e3
chore: added changeset
petertonysmith94 2058680
fix: pass correct provider reference
petertonysmith94 3e2d016
fix: removed @todo
petertonysmith94 2fa228b
test: added missing provider argument
petertonysmith94 81890e6
Merge branch 'master' into ps/feat/allow-wallet-creation-without-prov…
danielbate 5823bd0
Merge branch 'master' into ps/feat/allow-wallet-creation-without-prov…
Torres-ssf 7ca4b73
fix: testing a fix for pipeline adding github token
petertonysmith94 70448a6
Merge branch 'rc/salamander' into ps/feat/allow-wallet-creation-witho…
arboleya f1d2b04
Merge branch 'rc/salamander' into ps/feat/allow-wallet-creation-witho…
arboleya 82d56d6
Revert " fix: testing a fix for pipeline adding github token"
petertonysmith94 09d7cb5
Merge branch 'rc/salamander' into ps/feat/allow-wallet-creation-witho…
danielbate d7b4f83
chore: added changeset
petertonysmith94 ee12bca
Merge branch 'rc/salamander' into ps/feat/allow-wallet-creation-witho…
arboleya dc980a2
Merge branch 'rc/salamander' into ps/feat/allow-wallet-creation-witho…
Torres-ssf 6b80ac4
Merge branch 'rc/salamander' into ps/feat/allow-wallet-creation-witho…
Torres-ssf 25e4178
Merge branch 'rc/salamander' into ps/feat/allow-wallet-creation-witho…
Torres-ssf 3fa4c9d
Merge branch 'rc/salamander' into ps/feat/allow-wallet-creation-witho…
Torres-ssf e6519ce
Merge branch 'rc/salamander' into ps/feat/allow-wallet-creation-witho…
arboleya ede3baa
Merge branch 'rc/salamander' into ps/feat/allow-wallet-creation-witho…
Torres-ssf b72afbc
Merge branch 'rc/salamander' into ps/feat/allow-wallet-creation-witho…
danielbate 10fd09f
docs: added optional provider documentation
petertonysmith94 4b806d9
chore: removed unnecessary changeset
petertonysmith94 f1f6b54
chore: removed unnecessary import
petertonysmith94 32dd3b6
docs: thinking about context of docs
petertonysmith94 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@fuel-ts/wallet": minor | ||
--- | ||
|
||
Made provider argument optional for wallet instantiation |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FuelLabs/sdk-ts Just a reminder that code snippets should ideally come from the
apps/docs-snippets.