-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent overflow while decoding param types #1227
Conversation
73aa573
to
1c3f876
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job finding this issue and fixing it. LGTM, but I agree with @MujkicA's suggestions; it'll make a lot nicer to the eyes.
@FuelLabs/sdk-rust can we please move this forward |
Closes #1215 by fixing the way encoding size is computed