feat!: resolve witness indexes automatically #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hal3e
requested review from
MujkicA,
segfault-magnet,
Salka1988 and
Br1ght0ne
as code owners
hal3e
changed the title
MujkicA
reviewed
Aug 1, 2023
MujkicA
reviewed
Aug 1, 2023
MujkicA
reviewed
Aug 1, 2023
|
Regarding tests, we could include a case with multiple inputs coming from different wallets for a simple transfer and one for a create transaction |
6 tasks
segfault-magnet
previously approved these changes
Aug 7, 2023
Br1ght0ne
previously approved these changes
Aug 7, 2023
|
I will turn this PR into a draft. Even though I implemented the requested feature, we still have some use-cases with witnesses we need to cover. I will soon make a new version and then we can discuss it. |
iqdecay
previously approved these changes
Aug 21, 2023
MujkicA
reviewed
Aug 22, 2023
MujkicA
reviewed
Aug 22, 2023
segfault-magnet
previously approved these changes
Aug 23, 2023
Salka1988
previously approved these changes
Aug 23, 2023
MujkicA
approved these changes
Aug 24, 2023
MujkicA
previously approved these changes
Aug 24, 2023
MujkicA
dismissed stale reviews from segfault-magnet, Salka1988, and themself
via
2718b1f
MujkicA
approved these changes
Aug 24, 2023
segfault-magnet
approved these changes
Aug 24, 2023
Salka1988
approved these changes
Aug 24, 2023
segfault-magnet
pushed a commit
that referenced
this pull request
Aug 28, 2023
closes: #965 BREAKING CHANGE: - `send_transaction`, `dry_run`, `dry_run_no_validation` and `estimate_transaction_cost` need ownership of the `tx`. - removed witness index from `Input` and corresponding functions - wallet's `sign_transaction` now accepts a `TransactionBuilder` Co-authored-by: MujkicA <ahmedmujkic2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #965
Previously, when spending signed resource, the user had to manually set
witnessindexes. This meant that the user had to pay attention on the signing order and make sure to offset the index if some witnesses where already set.This PR automates the whole process.
Proposed workflow:
sign_transactionnow accepts aTransactionBuilderTransactionBuilderthe intention is saved inUnresolvedSignaturesappend_witness- this allows the user to add custom witnesses and it will not affect theTxIdAdditionally, building a transaction will fail if there are signed resources that are missing corresponding signatures.
BREAKING CHANGE:
send_transaction,dry_run,dry_run_no_validationandestimate_transaction_costneed ownership of thetx.Inputand corresponding functionssign_transactionnow accepts aTransactionBuilderChecklist