-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: set max_connections sqlx parameter #1508
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lostman these manifest files need to be corrected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected. Awesome @lostman
Description
Fixes #1507.
The default value for
max_connections
insqlx
is10
. From some testing, our number of DB connections per indexer can go up to ~6 and so, runningfuel-indexer
with more than one indexer could lead to failures.This PR sets the default to
100
and adds a CLI flag to modify it.Also, a warning will be issued if the set config value exceeds what is set in the backend.
Testing steps
Should succeed.
Example: with --num-additional-indexers 10
we get up to
43` connectionsChangelog
sqlx
parameter