bugfix: fix bytes encoding in entity::find #1482
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1480.
The issue was an incorrect conversion of (various)
bytes
scalars tosqlparser::Value
asSingleQuotedByteStringLiteral
.All
bytes
scalars are stored as lower-hex encoded strings. Thus, changing the conversion tosql::Value::SingleQuotedString(hex::encode(self))
fixes the issue.Testing steps
The same testing steps as outlined in #1480.
This PR also adds a couple of test cases.
Changelog
ToSQLValue
encoding of bytes[u8]
scalar types