Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alpha = roughness squared in microfacet BRDF #15

Open
Feez2403 opened this issue Jun 6, 2024 · 1 comment
Open

alpha = roughness squared in microfacet BRDF #15

Feez2403 opened this issue Jun 6, 2024 · 1 comment

Comments

@Feez2403
Copy link

Feez2403 commented Jun 6, 2024

Hello again :)

I am looking into the BRDF you are using.

Why is alpha = roughness squared (gamma(x) ^2) in your work ?

The original paper https://www.graphics.cornell.edu/~bjw/microfacetbsdf.pdf
just takes alpha values without squaring them.

Is it just a way to remove negative roughness when training ?

@FrozenBurning
Copy link
Owner

Thanks for your interest in our work! We refer you to the implementation of the BRDF used in NeRFactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants