Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add archive.org as sharing service #5096

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Add archive.org as sharing service #5096

merged 2 commits into from
Feb 22, 2023

Conversation

yzqzss
Copy link
Contributor

@yzqzss yzqzss commented Feb 11, 2023

Changes proposed in this pull request:

  • add archive.org as sharing service

How to test the feature manually:

  1. share an article.
  2. wait ten seconds. (The waiting time will be longer when the Internet Archive is overloaded)
  3. automatically redirect to the snapshot URL.

Pull request checklist:

  • clear commit messages
  • code manually tested
  • unit tests written (optional if too hard)
  • documentation updated

@math-GH math-GH added this to the 1.21.0 milestone Feb 11, 2023
@yzqzss
Copy link
Contributor Author

yzqzss commented Feb 12, 2023

Merging is blocked: The base branch requires all commits to be signed

Do I need to remake the PR?

Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait to see what @Alkarex says.

@Alkarex
Copy link
Member

Alkarex commented Feb 12, 2023

It is nice if all commits are signed (you can check GitHub documentation on how to do that) but we can merge nevertheless.
My connectivity is very poor at the moment. Did you have a chance to check the functionality @Frenzie ?

@Frenzie
Copy link
Member

Frenzie commented Feb 12, 2023

@Alkarex The link is (probably) fine, yes.

image

I can't speak as to the Internet Archive. I guess it must be overloaded. Minutes and counting. :-)

Edit: it just came back with a job failed, fwiw. https://web.archive.org/save/https://smashingmagazine.com/2022/12/taking-stress-out-design-system-management/

@math-GH
Copy link
Contributor

math-GH commented Feb 12, 2023

I checked the functionality and it works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants