Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: wrong dropdown triangle of labels category #4174

Merged
merged 2 commits into from
Jan 26, 2022

Conversation

math-GH
Copy link
Contributor

@math-GH math-GH commented Jan 25, 2022

Summary:
shows the triangle to bottom: dropdown is closed
shows the triangle to top: dropdown is open

Example 1

Before:
grafik

After:
grafik

Example 2

Before:
grafik

After:
grafik

Example 3

Before:
grafik

After:
grafik

Changes proposed in this pull request:

  • improved the logic of the triangle icon

How to test the feature manually:

  1. filter: show only unread articles, labels has some unread articles
  2. filter: show unread and read articles, labels has some unread articles
  3. filter: show unread and read articles, labels has no unread articles

Pull request checklist:

  • clear commit messages
  • code manually tested

@math-GH math-GH added the UI 🎨 User Interfaces label Jan 25, 2022
@math-GH math-GH added this to the 1.19.2 milestone Jan 25, 2022
@Alkarex
Copy link
Member

Alkarex commented Jan 25, 2022

The bug was only with the option to unfold all categories by default, right?

@math-GH
Copy link
Contributor Author

math-GH commented Jan 26, 2022

The bug was only with the option to unfold all categories by default, right?

it is independent.

Here my "reading" settings from the screenshots above
grafik

@Alkarex Alkarex merged commit cf433d4 into FreshRSS:edge Jan 26, 2022
@math-GH math-GH deleted the fix-wrong-triangle-labels branch January 27, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI 🎨 User Interfaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants