Detect enclosure as images using file extension #3861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support e.g. https://www.sciencesetavenir.fr/atom.xml , which does not include any type hint. ```html <link rel="enclosure" href="https://example.net/assets/img/ZZZ.jpg" title="YYY"/> ``` Useful for FreshRSS#3805
Alkarex
force-pushed
the
enclosure_sniff_extension
branch
from
39e2a32
to
a156529
Compare
Frenzie
reviewed
Sep 27, 2021
app/Models/Feed.php
Outdated
| @@ -410,7 +410,8 @@ public function loadEntries($simplePie) { | |||
| $height = $enclosure->get_height(); | |||
| $width = $enclosure->get_width(); | |||
| $length = $enclosure->get_length(); | |||
| if ($medium === 'image' || strpos($mime, 'image') === 0 || ($mime == '' && $length == null && ($width != 0 || $height != 0))) { | |||
| if ($medium === 'image' || strpos($mime, 'image') === 0 || | |||
| ($mime == '' && $length == null && ($width != 0 || $height != 0 || preg_match('/[.](gif|jpe?g|png|svg)$/i', $elink)))) { | |||
There was a problem hiding this comment.
Should probably also add WebP and that new one based on AV1.
Frenzie
approved these changes
Sep 27, 2021
Indeed, and several more, cf. e.g. https://developer.mozilla.org/docs/Web/Media/Formats/Image_types , but this is just a fallback for cases not providing any other type hint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support e.g. https://www.sciencesetavenir.fr/atom.xml , which does not include any type hint:
Useful for #3805