Hide feed credentials when adding a new feed #3099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid showing HTTP Basic Auth credentials in feed error log and in feed title (when there is no title provided)
Alkarex
commented
Jul 6, 2020
| @@ -287,7 +287,7 @@ public function load($loadDetails = false, $noCache = false) { | |||
| if ((!$mtime) || $simplePie->error()) { | |||
| $errorMessage = $simplePie->error(); | |||
| throw new FreshRSS_Feed_Exception( | |||
| ($errorMessage == '' ? 'Unknown error for feed' : $errorMessage) . ' [' . $url . ']' | |||
| ($errorMessage == '' ? 'Unknown error for feed' : $errorMessage) . ' [' . $this->url . ']' | |||
There was a problem hiding this comment.
$this->url does not contain the user:password component, unlike $url which does
marienfressinaud
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid showing HTTP Basic Auth credentials in feed error log and in feed
title (when there is no title provided)