Manual update to SimplePie 1.5.3

[candrews]

Changelogs:

• https://github.com/simplepie/simplepie/releases/tag/1.5.3

I've manually applied these changes:
https://github.com/simplepie/simplepie/compare/1.5.2..1.5.3

This is of particular interest as it eliminates some warnings when run with PHP 7.4:

PHP Deprecated:  implode(): Passing glue string after array is deprecated. Swap the parameters in /var/www/localhost/htdocs/FreshRSS/lib/SimplePie/SimplePie/Parse/Date.php on line 544
PHP Deprecated:  implode(): Passing glue string after array is deprecated. Swap the parameters in /var/www/localhost/htdocs/FreshRSS/lib/SimplePie/SimplePie/Parse/Date.php on line 545

See simplepie/simplepie@38b5049

[candrews]

Is there anything else that I can / should do to help this along?

[Alkarex]

Hello,
The update must be done much more carefully. The version of SimplePie shipped with FreshRSS contains a number of additional features and modifications which have not been accepted upstream, or for which we have not taken the time to make a pull request upstream (e.g. hash-based caching, forced HTTPs, syslog logging, handling of some encodings...).
The current PR would crash FreshRSS.

[candrews]

I've updated this PR.

I now started with the current files in FreshRSS's repo and manually applied the SimpliePie 1.5.2->1.5.3 changes from https://github.com/simplepie/simplepie/compare/1.5.2..1.5.3

I believe that should be much more acceptable :)

[marienfressinaud]

It looks good to me. Note for the other reviewers that the fix of SimplePie/Cache/File.php was already applied in 0fb21e1

[Alkarex]

Thanks @candrews