Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Docker #1813

Merged
merged 4 commits into from
Mar 4, 2018
Merged

New Docker #1813

merged 4 commits into from
Mar 4, 2018

Conversation

Alkarex
Copy link
Member

@Alkarex Alkarex commented Mar 3, 2018

@Alkarex
Copy link
Member Author

Alkarex commented Mar 3, 2018

I would like to redirect both https://github.com/FreshRSS/docker-freshrss and https://github.com/FreshRSS/docker-freshrss-production to this new version. Any comments?

@Frenzie
Copy link
Member

Frenzie commented Mar 3, 2018

I'm not entirely convinced it belongs in the main repo but that's not a real objection, just a very slightly raised eyebrow. But yeah, two mini repos is a bit much.

@Alkarex
Copy link
Member Author

Alkarex commented Mar 3, 2018

Having it in the same repository makes the scenarios of using git update + Docker (e.g. for development or testing) easier.
And a bit like with the documentation, it is also easier to maintain the versions in sync (a Dockerfile might change with a new FreshRSS version).
P.S.: Also more convenient for automated builds

@Alkarex
Copy link
Member Author

Alkarex commented Mar 3, 2018

For the record, I initially planned to use php:7.2-apache as a base image, but the large size and manual handling of library configurations and dependencies made me move to Alpine instead.

Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request Mar 3, 2018
HTTP_HOST sometimes contains a port number.
This made FreshRSS to generate a public URL with two times the port,
like https://freshrss.example:8080:8080/
Needed for FreshRSS#1813
@Alkarex Alkarex mentioned this pull request Mar 3, 2018
@Alkarex Alkarex changed the title Draft of new Docker New Docker Mar 3, 2018
.dockerignore Outdated
@@ -0,0 +1,10 @@
*/.git
*/docs
*/data/config.php
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, maybe we should exclude all */data/. Will do that tomorrow.

@Alkarex Alkarex merged commit 71918db into FreshRSS:dev Mar 4, 2018
@Alkarex
Copy link
Member Author

Alkarex commented Mar 4, 2018

Merging to try auto-build on https://hub.docker.com/r/freshrss/freshrss/
Let's open a new PR for any remaining change.

@Alkarex Alkarex deleted the Docker branch March 4, 2018 00:02
@Alkarex
Copy link
Member Author

Alkarex commented Mar 4, 2018

Use cloud.docker.com instead of hub.docker.com, to get better auto-build features:
https://cloud.docker.com/app/freshrss/repository/docker/freshrss/freshrss/general

@Alkarex
Copy link
Member Author

Alkarex commented Mar 4, 2018

@aledeg and @Frenzie Let me know if you have an account on cloud.docker.com so I can add you in the team (already done for @marienfressinaud )

sudo docker pull freshrss/freshrss
# And then
sudo docker stop freshrss
docker rename freshrss freshrss_old
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't sudo missing here ? ( and two lines below ) or maybe this section should not have sudo, assuming user will use sudo if it's needed in his environment

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #1817

@Alkarex
Copy link
Member Author

Alkarex commented Mar 4, 2018

An automatic build is already working on the dev branch. To test:

mkdir -p ./data/
sudo docker run -dit --restart unless-stopped --log-opt max-size=10m -v $(pwd)/data:/var/www/FreshRSS/data -p 8080:80 --name freshrss freshrss/freshrss:dev

Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request Mar 4, 2018
@Alkarex Alkarex mentioned this pull request Mar 4, 2018
@Alkarex
Copy link
Member Author

Alkarex commented Mar 4, 2018

Follow-up in #1817

@Frenzie
Copy link
Member

Frenzie commented Mar 4, 2018

@Alkarex

Let me know if you have an account on cloud.docker.com so I can add you in the team

The sign-up is a half-broken nightmare (complains about things without telling you what's wrong, expiring validations, etc.) but at least it didn't complain that my password was too long or contained difficult characters.

Anyway, my username is frenzie.

@Alkarex
Copy link
Member Author

Alkarex commented Mar 4, 2018

@Frenzie Done 👍

Alkarex added a commit that referenced this pull request Mar 4, 2018
HTTP_HOST sometimes contains a port number.
This made FreshRSS to generate a public URL with two times the port,
like https://freshrss.example:8080:8080/
Needed for #1813
Alkarex added a commit that referenced this pull request Mar 4, 2018
@Alkarex Alkarex mentioned this pull request Mar 4, 2018
Alkarex added a commit that referenced this pull request Mar 4, 2018
* Docker follow-up

#1813

* Readme links

cloud.docker.com does not seem to have a public version of the pages
re-add https://hub.docker.com/r/freshrss/freshrss/

* Link to original GitHub readme

* Docker readme MySQL PostgreSQL

#1817 (comment)

* docker exec username
javerous pushed a commit to javerous/FreshRSS that referenced this pull request Jan 20, 2020
* Draft of new Docker

Based on Alpine Linux. Size ~78MB.
FreshRSS/docker-freshrss#4
FreshRSS#520
https://github.com/FreshRSS/docker-freshrss
https://github.com/FreshRSS/docker-freshrss-production

* Docker readme

* +x execution rights prepare

* Docker readme links to hub.docker.com

https://hub.docker.com/r/freshrss/freshrss/
javerous pushed a commit to javerous/FreshRSS that referenced this pull request Jan 20, 2020
HTTP_HOST sometimes contains a port number.
This made FreshRSS to generate a public URL with two times the port,
like https://freshrss.example:8080:8080/
Needed for FreshRSS#1813
javerous pushed a commit to javerous/FreshRSS that referenced this pull request Jan 20, 2020
javerous pushed a commit to javerous/FreshRSS that referenced this pull request Jan 20, 2020
* Docker follow-up

FreshRSS#1813

* Readme links

cloud.docker.com does not seem to have a public version of the pages
re-add https://hub.docker.com/r/freshrss/freshrss/

* Link to original GitHub readme

* Docker readme MySQL PostgreSQL

FreshRSS#1817 (comment)

* docker exec username
mdemoss pushed a commit to mdemoss/FreshRSS that referenced this pull request Mar 25, 2021
* Draft of new Docker

Based on Alpine Linux. Size ~78MB.
FreshRSS/docker-freshrss#4
FreshRSS#520
https://github.com/FreshRSS/docker-freshrss
https://github.com/FreshRSS/docker-freshrss-production

* Docker readme

* +x execution rights prepare

* Docker readme links to hub.docker.com

https://hub.docker.com/r/freshrss/freshrss/
mdemoss pushed a commit to mdemoss/FreshRSS that referenced this pull request Mar 25, 2021
HTTP_HOST sometimes contains a port number.
This made FreshRSS to generate a public URL with two times the port,
like https://freshrss.example:8080:8080/
Needed for FreshRSS#1813
mdemoss pushed a commit to mdemoss/FreshRSS that referenced this pull request Mar 25, 2021
mdemoss pushed a commit to mdemoss/FreshRSS that referenced this pull request Mar 25, 2021
* Docker follow-up

FreshRSS#1813

* Readme links

cloud.docker.com does not seem to have a public version of the pages
re-add https://hub.docker.com/r/freshrss/freshrss/

* Link to original GitHub readme

* Docker readme MySQL PostgreSQL

FreshRSS#1817 (comment)

* docker exec username
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants