-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Docker #1813
New Docker #1813
Conversation
I would like to redirect both https://github.com/FreshRSS/docker-freshrss and https://github.com/FreshRSS/docker-freshrss-production to this new version. Any comments? |
I'm not entirely convinced it belongs in the main repo but that's not a real objection, just a very slightly raised eyebrow. But yeah, two mini repos is a bit much. |
Having it in the same repository makes the scenarios of using git update + Docker (e.g. for development or testing) easier. |
For the record, I initially planned to use |
HTTP_HOST sometimes contains a port number. This made FreshRSS to generate a public URL with two times the port, like https://freshrss.example:8080:8080/ Needed for FreshRSS#1813
.dockerignore
Outdated
@@ -0,0 +1,10 @@ | |||
*/.git | |||
*/docs | |||
*/data/config.php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum, maybe we should exclude all */data/
. Will do that tomorrow.
Merging to try auto-build on https://hub.docker.com/r/freshrss/freshrss/ |
Use cloud.docker.com instead of hub.docker.com, to get better auto-build features: |
@aledeg and @Frenzie Let me know if you have an account on cloud.docker.com so I can add you in the team (already done for @marienfressinaud ) |
sudo docker pull freshrss/freshrss | ||
# And then | ||
sudo docker stop freshrss | ||
docker rename freshrss freshrss_old |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't sudo
missing here ? ( and two lines below ) or maybe this section should not have sudo
, assuming user will use sudo
if it's needed in his environment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well spotted :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #1817
An automatic build is already working on the dev branch. To test: mkdir -p ./data/
sudo docker run -dit --restart unless-stopped --log-opt max-size=10m -v $(pwd)/data:/var/www/FreshRSS/data -p 8080:80 --name freshrss freshrss/freshrss:dev |
Follow-up in #1817 |
The sign-up is a half-broken nightmare (complains about things without telling you what's wrong, expiring validations, etc.) but at least it didn't complain that my password was too long or contained difficult characters. Anyway, my username is |
@Frenzie Done 👍 |
HTTP_HOST sometimes contains a port number. This made FreshRSS to generate a public URL with two times the port, like https://freshrss.example:8080:8080/ Needed for #1813
* Docker follow-up #1813 * Readme links cloud.docker.com does not seem to have a public version of the pages re-add https://hub.docker.com/r/freshrss/freshrss/ * Link to original GitHub readme * Docker readme MySQL PostgreSQL #1817 (comment) * docker exec username
* Draft of new Docker Based on Alpine Linux. Size ~78MB. FreshRSS/docker-freshrss#4 FreshRSS#520 https://github.com/FreshRSS/docker-freshrss https://github.com/FreshRSS/docker-freshrss-production * Docker readme * +x execution rights prepare * Docker readme links to hub.docker.com https://hub.docker.com/r/freshrss/freshrss/
HTTP_HOST sometimes contains a port number. This made FreshRSS to generate a public URL with two times the port, like https://freshrss.example:8080:8080/ Needed for FreshRSS#1813
* Docker follow-up FreshRSS#1813 * Readme links cloud.docker.com does not seem to have a public version of the pages re-add https://hub.docker.com/r/freshrss/freshrss/ * Link to original GitHub readme * Docker readme MySQL PostgreSQL FreshRSS#1817 (comment) * docker exec username
* Draft of new Docker Based on Alpine Linux. Size ~78MB. FreshRSS/docker-freshrss#4 FreshRSS#520 https://github.com/FreshRSS/docker-freshrss https://github.com/FreshRSS/docker-freshrss-production * Docker readme * +x execution rights prepare * Docker readme links to hub.docker.com https://hub.docker.com/r/freshrss/freshrss/
HTTP_HOST sometimes contains a port number. This made FreshRSS to generate a public URL with two times the port, like https://freshrss.example:8080:8080/ Needed for FreshRSS#1813
* Docker follow-up FreshRSS#1813 * Readme links cloud.docker.com does not seem to have a public version of the pages re-add https://hub.docker.com/r/freshrss/freshrss/ * Link to original GitHub readme * Docker readme MySQL PostgreSQL FreshRSS#1817 (comment) * docker exec username
Based on Alpine Linux. Size ~78MB.
FreshRSS/docker-freshrss#4
#520
https://github.com/FreshRSS/docker-freshrss
https://github.com/FreshRSS/docker-freshrss-production