Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomCSS - need to add "!important" to CSS elements #13

Closed
gabrielcossette opened this issue Feb 19, 2017 · 3 comments
Closed

CustomCSS - need to add "!important" to CSS elements #13

gabrielcossette opened this issue Feb 19, 2017 · 3 comments

Comments

@gabrielcossette
Copy link

Hi,

I'm using the CustomCSS extension and I need to add "!important" at the end of each elements in order to work. Otherwise, they are overridden.

Is that the expected behavior? If yes, I suggest we add this important precision to the README.

Thanks!

@Alkarex
Copy link
Member

Alkarex commented Feb 22, 2017

Hello,
Could you please provide an example of rule for which you need to add !important?
In CSS, the most precise rule wins, or the last rule when several rules are equally precise. I suspect the CSS rules you are trying to add are not precise enough (less qualified).

@gabrielcossette
Copy link
Author

Here's an example:

A custom rule:

.content {
    min-height: auto !important;
}

To replace:

.content {
    min-height: 20em;

set by "p/themes/base-theme/template.css"

As they are equally precise, I assume the normal behaviour would be that CustomCSS would override it. Maybe it's not loaded after template.css?

@Alkarex
Copy link
Member

Alkarex commented May 26, 2017

Fixed in FreshRSS/FreshRSS#1547 (upcoming FreshRSS 1.7.0). Tests of /dev branch welcome.

@Alkarex Alkarex closed this as completed May 26, 2017
Alkarex added a commit to Alkarex/FreshRSS that referenced this issue May 26, 2017
javerous pushed a commit to javerous/FreshRSS that referenced this issue Jan 20, 2020
javerous pushed a commit to javerous/FreshRSS that referenced this issue Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants