Replies: 3 comments
-
Great idea! |
Beta Was this translation helpful? Give feedback.
0 replies
-
Can also be done for |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Current
inline void setHandleMessage(void (*fptr)(const MidiMessage&)) { mMessageCallback = fptr; };
Suggestion:
inline MidiInterface& setHandleMessage(void (*fptr)(const MidiMessage&)) { mMessageCallback = fptr; return *this; };
(add
MidiInterface&
for all callbacks)This would allow for:
Shorter and syntactically nicer
A suggestion for a next release.
This has no impact on the use of dynamic memory usage or program storage space.
And no impact on existing code and examples
Beta Was this translation helpful? Give feedback.
All reactions