Replies: 1 comment 2 replies
-
Added PR #218 for the end() method for the Serial Transport layer |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
The library provides a
begin()
method to open the communication with the Transport layer, but no opposite method is provided (end()
) to close the communication with the Transport layer.Use-case: an interruption in the Transport protocol, causing a breakdown of the Transport layer can't be fixed by restarting the MIDI object - due to the missing
end()
method.A restart of the Transport layer could be forced by calling
MIDI.end(); MIDI.begin();
Impact: all underlying Transport mechanisms have to implement the end() method, so the impact on backward compatibility (on the Transport layers) and dependancy on a specific version of this library is significant and needs to be planned carefully.
Beta Was this translation helpful? Give feedback.
All reactions