-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error on className
with React 19
#560
Comments
I just noticed there is already a PR to fix this, hopefully it will be merged quickly. |
I just released 0.2.1 which I think will fix this. Can you all retest? |
i just pulled down 0.2.1 and my application is now showing this error. i had to roll back to 0.2.0 to resolve. I'm using react 18.3.1, font awesome 6.5.2. with 0.2.1 it wont fail if i supply a className, but my primary use-case doesn't supply unless its needed. Im fine with supplying if thats a new requirement. |
I can confirm that version |
Describe the bug
On React 19 (beta), an error is thrown if
className
is not passed to<FontAwesomeIcon>
.I believe it's the same bug as the one reported on this issue, except that now it happens even when no
className
is specified.Reproducible test case
https://codesandbox.io/p/sandbox/react-19-font-awesome-k6n8ww?file=%2Fsrc%2FApp.js%3A11%2C51
Error on the sandbox:
I get a different error when I try it on my app (maybe it depends on the bundler config):
Expected behavior
The error is fixed when adding a
className
, but this prop should not be required.Setup
6.5.2
0.2.0
19.0.0-beta-6946ebe620-20240508
The text was updated successfully, but these errors were encountered: