Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(events-subscription): allow to instantly refresh permissions when they change #1039

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

Thenkei
Copy link
Member

@Thenkei Thenkei commented May 31, 2023

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)
  • Ensure that Types have been updated according to your changes (if needed)

Security

  • Consider the security impact of the changes made

@Thenkei Thenkei force-pushed the feat/refresh-using-event-source branch from 97f05e2 to 5b070f2 Compare June 12, 2023 12:28
package.json Outdated
@@ -27,7 +27,7 @@
"dependencies": {
"@babel/runtime": "7.15.4",
"bluebird": "2.9.25",
"forest-express": "10.1.12",
"forest-express": "10.2.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"forest-express": "10.2.0",
"forest-express": "10.2.1",

@Thenkei Thenkei force-pushed the feat/refresh-using-event-source branch from 5b070f2 to 1487d9b Compare June 12, 2023 12:40
@Thenkei Thenkei force-pushed the feat/refresh-using-event-source branch from 1487d9b to bfd7c01 Compare June 12, 2023 14:22
@codeclimate
Copy link

codeclimate bot commented Jun 12, 2023

Code Climate has analyzed commit bfd7c01 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (95% is the threshold).

This pull request will bring the total coverage in the repository to 86.7%.

View more on Code Climate.

@Thenkei Thenkei merged commit 6bb5e5e into main Jun 12, 2023
@Thenkei Thenkei deleted the feat/refresh-using-event-source branch June 12, 2023 14:25
forest-bot added a commit that referenced this pull request Jun 12, 2023
# [9.3.0](v9.2.10...v9.3.0) (2023-06-12)

### Features

* **events-subscription:** allow to instantly refresh permissions when they change ([#1039](#1039)) ([6bb5e5e](6bb5e5e))
@forest-bot
Copy link
Member

🎉 This PR is included in version 9.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants