Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental build doesn't work #39

Closed
johannesegger opened this issue Jul 17, 2017 · 3 comments
Closed

Incremental build doesn't work #39

johannesegger opened this issue Jul 17, 2017 · 3 comments
Milestone

Comments

@johannesegger
Copy link

johannesegger commented Jul 17, 2017

I'm getting the following error when building a project that is up-to-date:

...\packages\Equals.Fody.1.7.1\build\dotnet\Equals.Fody.targets(13,5): error : Equals expected to be executed. You may need to manually add '<Equals />' into your FodyWeavers.xml. eg . See https://github.com/Fody/Fody/wiki/SampleUsage

Interestingly I only get that error when I build from the command line using msbuild Solution.sln, building from within VS works totally fine.

The responsible part is here. It seems reasonable that the list of executed weavers is empty, if the weavers executed in a previous build, right?

EDIT: I just checked and I can reproduce this in a clean project.
EDIT: It doesn't work with Equals.Fody 1.7.1 and Fody 2.1.1 but it works with Equals.Fody 1.6.2 and Fody 1.29.4

@CraigN
Copy link

CraigN commented Nov 21, 2017

I can validate this issue. It happens using the new VS2017 project format but only when you build and don't do a clean and build or rebuild.

@SimonCropp
Copy link
Member

can u try v 1.8

@johannesegger
Copy link
Author

I tried it on a clean project again and it worked, thanks a lot.

@SimonCropp SimonCropp added this to the 1.8.0 milestone Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants