Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: no request object in v:render.template #1902

Open
queosailor opened this issue Mar 13, 2024 · 0 comments · May be fixed by #1907
Open

BUG: no request object in v:render.template #1902

queosailor opened this issue Mar 13, 2024 · 0 comments · May be fixed by #1907

Comments

@queosailor
Copy link

I have checked that the bug exists in the dev-development branch
No

I have checked that there are no already open issues or recently closed issues about this bug
Yes

Describe the bug
If a template is included with v:render.template, no request object is available to the viewhelpers of the template.
e.g. f:translate is then no longer able to determine the site language
Also the f:email.link viewhelper is not able to spamprotect email adresses.

I Added 2 patches which solve these Problems:

add_request2.patch
add_request.patch
@queosailor queosailor changed the title BUG: foobar fails when baz no request object in v:render.template Mar 13, 2024
@queosailor queosailor changed the title no request object in v:render.template BUG: no request object in v:render.template Mar 14, 2024
@christophlehmann christophlehmann linked a pull request May 25, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TemplateViewHelper: Use ServerRequest christophlehmann/vhs
1 participant
@queosailor