Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into removing firehed/security as a hard dependency #15

Open
Firehed opened this issue Apr 5, 2023 · 0 comments
Open

Look into removing firehed/security as a hard dependency #15

Firehed opened this issue Apr 5, 2023 · 0 comments

Comments

@Firehed
Copy link
Owner

Firehed commented Apr 5, 2023

Since the #[SensitiveParameter] attribute has native support in PHP 8.2, one of the main reasons for importing and relying on this library has become obsolete (currently-supported versions of PHP notwithstanding).

In practice, I've found a combination of __debugInfo() (#13) and sensible setup makes this mostly into added API complexity. Removing it as a requirement is generally beneficial as it reduces dependency surface area and is one less thing to deal with when dealing with language version updates. If it can be moved to suggest and left optional, I think that's a net win.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant