-
-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 Make env picklable #269
🔧 Make env picklable #269
Conversation
Thank you for the PR @MathisFederico. I suggest a few changes. I left a comment for the testing function, and could you update the docs for the MissionSpace class (use static method function instead of lambda function). |
Show use of static function instead of lambdas for picklability
Sure ! Where can I find your suggestions ? I don't think you published your review if you have done one !
Done in last commit ! |
Thanks! I just tagged you on it, under |
Not sure where to see the tag ... I guess it's on GitHub as I don't see any new commit from your part, but I can't seem to find where you tagged me ^^' You may want to use GitHub review system, I've had good experiences with that ! |
@MathisFederico can you see the review now? |
Yes ! Sorry I did not have time for now, I may do this tonight if I can find the time ! |
Done ! @rodrigodelazcano |
Description
I needed envs to be picklable for using them in multiple process.
Thus I fixed the issue that happens to be lambda functions used for missions generation.
Fixes to fact that envs were not picklable.
Type of change
Please delete options that are not relevant.
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)