Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempted to fix list_remote_datasets slowdown #124

Merged

Conversation

balisujohn
Copy link
Collaborator

@balisujohn balisujohn commented Jul 23, 2023

Description

This PR attempts to fix the slowdown to list_remote_datasets introduced in 0.4.0.

0.4.1 average runtime: 3.2189864999999998
0.3.1 average runtime: average runtime: 0.2429087
patched version: average runtime: 0.7913758999999999

n=20

I will also re-run this profiling with n=100 prior to marking this ready for review, since the Google bucket response times seem to add a lot of variance. (I redid n=20 and results seem to replicate well enough I'm convinced this patch is worthwhile)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@balisujohn balisujohn marked this pull request as draft July 23, 2023 21:54
@balisujohn balisujohn marked this pull request as ready for review August 4, 2023 23:25
@balisujohn balisujohn merged commit e1d5658 into Farama-Foundation:main Aug 10, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants