Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect documentation for some mouse hooks #680

Closed
JordanMartinez opened this issue Feb 9, 2018 · 1 comment
Closed

Incorrect documentation for some mouse hooks #680

JordanMartinez opened this issue Feb 9, 2018 · 1 comment
Labels
documentation

Comments

@JordanMartinez
Copy link
Contributor

Discovered in #656:

  • onNewSelectionDrag: copied-and-pasted from onSelectionDrag. This should specify that the hook is run every time the user continues to drag the mouse after pressing on some unselected text but has not yet released the mouse
  • onNewSelectionFinished: copied-and-pasted from onSelectionDrag. This should specify that the hook is run when the user releases the mouse after pressing the mouse on some unselected text and dragging the mouse to a new location
@JordanMartinez JordanMartinez mentioned this issue Feb 9, 2018
Merged
@JordanMartinez
Copy link
Contributor Author

Closed by #681.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JordanMartinez