Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text horizontally out of the viewport does not become visible when vieport size is increased #412

Closed
synth3 opened this issue Jan 4, 2017 · 5 comments

Comments

@synth3
Copy link

synth3 commented Jan 4, 2017

I have found the a problem regarding scrolling end re-sizing. Since it's not easy to describe I just post the steps needed to reproduce and a GIF showing the behavior:

  • open the RichText demo
  • disable "wrap"
  • insert one long line of text
  • decrease the horizontal size of the window until a horizontal scroll bar is visible
  • scroll all the way to the right
  • increase the window size until the horizontal scrollbar dissapears
    -- Result: The content stays scrolled to the right
    -- Expected: Same behavior as for the vertical dimension (which works just fine)

screenrecording

Sidenote: As horizontal scrolling is broken with Flowless 0.5.1 I used a snapsot that was created from the current state of the Flowless repo.

@JordanMartinez
Copy link
Contributor

Good catch. Unfortunately, I don't understand Flowless' inner code that well, so I'm not the one who can determine where the bug is occurring and then fix it.

@JordanMartinez
Copy link
Contributor

This is another issue I want to look into after better documenting Flowless' code.

@JordanMartinez
Copy link
Contributor

I fixed the bug in FXMisc/Flowless#42. Just waiting for Tomas to merge it.

@JordanMartinez
Copy link
Contributor

JordanMartinez commented Jul 9, 2017

I've created a branch in my repo of RichTextFX called jitpack-master that includes the fix I've submitted. If you change your build to use that via Jitpack, then this bug will no longer appear. Follow these instructions to update your build to use it. You can revert your build to the next release whenever Tomas makes the next one including the fix.

Maven

Add the repository

<repositories>
    <repository>
        <id>jitpack.io</id>
        <url>https://jitpack.io</url>
    </repository>
</repositories>

Add the dependency

<dependency>
    <groupId>com.github.JordanMartinez</groupId>
    <artifactId>RichTextFX</artifactId>
    <version>jitpack-master-SNAPSHOT</version>
</dependency>

Gradle

repositories {
    maven {
        url 'https://jitpack.io'
    }
}

dependencies {
    compile "com.github.JordanMartinez:RichTextFX:jitpack-master-SNAPSHOT"
}

Sbt

resolvers += "jitpack" at "https://jitpack.io"

libraryDependencies += "com.github.JordanMartinez" % "RichTextFX" % "jitpack-master-SNAPSHOT"

@JordanMartinez
Copy link
Contributor

JordanMartinez commented Oct 3, 2017

This was fixed in the latest snapshot of Flowless (0.6-SNAPSHOT), so all one needs to do is refresh their dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants