You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Other tests are also running directly on GitHub action images. While I guess it reduces test runtime, I think it's better practice to start from a very minimal image and install what's needed (not a lot for Basix, presumably?).
There are quite a few C++20 features that are only supported in GCC11 and above, e.g.
using enum
would be a big one for code readability in basix.Currently we are using
ubuntu-20.04
and GCC10 GitHub runners (i.e. no Docker) forpythonapp.yml
: https://github.com/FEniCS/basix/blob/main/.github/workflows/pythonapp.ymlI would propose:
pythonapp.yml
inside a plain Ubuntu Docker container so that the dependancy surface is minimal and well-controlled.The text was updated successfully, but these errors were encountered: