Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getIdentifier() with "res" #49

Open
FAMILIAR-project opened this issue Mar 30, 2016 · 0 comments
Open

getIdentifier() with "res" #49

FAMILIAR-project opened this issue Mar 30, 2016 · 0 comments
Labels

Comments

@FAMILIAR-project
Copy link
Owner

Variable default behavior for getIdentifier() is to return either the name if it exists, or create a new fake identifier with "res" and an increment (eg res12 res13 and so on)
It is very dangerous since if you access multiple times getIdentifier() you don't get the same identifier.

I see the use case but it is too dangerous.
We should move the identifier creation logic to another place and basically modify the responsability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant